[Mondrian] RE: Eigenbase perforce change 12884 for review
rushan.chen at gmail.com
Fri Jun 19 12:58:24 EDT 2009
Thanks for the review.
This checkin is meant to be a first cut before I have to change machines. As
of now it still sits in the private branch. I will make sure when the branch
gets integrated, all the issues are addressed.
On Fri, Jun 19, 2009 at 9:16 AM, Julian Hyde <jhyde at pentaho.com> wrote:
> Very nice.
> Can you add a test case for this? Using a few crossjoins, it should be easy
> to construct an example query that takes (say) 2 minutes without your
> and 2 seconds after. If the functionality regressed, we would probably
> notice a 2 minute increase in the length of the test run.
> Btw, there are tabs all over your source code. I'm guessing you didn't run
> checkFile. :)
> > From: Rushan Chen [mailto:rchen at lucidera.com]
> > Subject: Eigenbase perforce change 12884 for review
> > http://p4web.eigenbase.org/@md=d&c=6PU@//12884?ac=10
> > Change 12884 by rchen at rchen.marmot.eigenbase on 2009/06/18 16:30:59
> > MONDRIAN: improve the performance of Rank function accepting 3
> > args. First cut of implemetation.
> Mondrian mailing list
> Mondrian at pentaho.org
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the Mondrian