[Mondrian] Better understanding of hierarchies without an All Member
wgorman at pentaho.com
Fri May 9 21:37:12 EDT 2014
Here's the change:
I also logged a JIRA case for the enhancement:
In addition to demonstrating the issue with calculated sets, it would be nice if folks had any other test cases in mind worth trying out.
From: mondrian-bounces at pentaho.org [mailto:mondrian-bounces at pentaho.org] On Behalf Of Julian Hyde
Sent: Friday, May 09, 2014 3:00 PM
To: Mondrian mailing list
Subject: Re: [Mondrian] Better understanding of hierarchies without an All Member
On May 9, 2014, at 2:46 PM, Will Gorman <wgorman at pentaho.com> wrote:
> How would people feel if we updated the logic to skip the nonAllMembers.add(rootMembers) if there is an explicit default member specified in the hierarchy? This approach would resolve the issue we're facing, and still allow the current behavior for implicit default members.
If nothing gets slower and no tests get broken, I don't object. Otherwise I will need to understand the change you are making a bit more. You could make a pull request and we could review that.
It's worth extending that test to deal with calculated sets specified in the query, not just in the schema.
By the way, that test case was written for http://jira.pentaho.com/browse/MONDRIAN-197. The bug wasn't completely fixed until Andreas Voss committed https://github.com/pentaho/mondrian/commit/7499ff00a8b8aa34ea14fc8a5f77703915ac9650.
Mondrian mailing list
Mondrian at pentaho.org
More information about the Mondrian