[Mondrian] Ready to move to maven?

Julian Hyde julianhyde at gmail.com
Mon Jul 14 13:59:22 EDT 2014


No objections; go ahead.

After it is committed to lagunitas, I might move log4j.properties and log4j.xml from root directory to src/test/resources. Then I can get rid of <testResources> altogether. (Under maven, the root directory is rarely the right place for a file. Which means less clutter. Yay.)

Julian

On Jul 14, 2014, at 6:38 AM, Kurtis Walker <kwalker at pentaho.com> wrote:

> I had to make another change to get all expected tests to pass.  https://github.com/kurtwalker/mondrian/commit/42d2b55fa0daac4041b5941bf223368868a6a381
> 
> Any objection to squashing all these into a single commit?
> 
> Kurt
> On Sat, 2014-07-12 at 23:48 -0500, Julian Hyde wrote:
>> 
>> Strange. I get 13 failures, 0 errors on lagunitas [1], and 12 failures, 0 errors on maven2 [2]. (One fewer failure because I fixed testCodeFormatting.)
>> 
>> 
>> .csv files now live under src/test/resources rather than testsrc/main. Maven copies them to target/test-classes, and the tests (e.g. RolapResultTest) look for them there. Maybe you're running 'ant test' but have not run 'mvn compile' or similar to copy them.
>> 
>> 
>> In my opinion, it's OK if that scenario doesn't work. If you run 'mvn compile' first, I think you'll find that maven2 is at parity with lagunitas.
>> 
>> 
>> Julian
>> 
>> 
>> [1] https://github.com/julianhyde/mondrian/commit/53bb59393ad5c116d3a1b4e8f4ce8d76698f8c8a
>> [2] https://github.com/julianhyde/mondrian/commit/69d5d7097165ea66f306a5d5e96613f77998a95f
>> 
>> 
>> On Sat, Jul 12, 2014 at 2:52 PM, Kurtis Walker <kwalker at pentaho.com> wrote:
>> yup, ant and mvn both have the same test results.  But, there are still six more failures compared to lagunitas.  All FileNotFoundException.  I think some csv resources are not getting included in the compile.
>> 
>> 
>> On Fri, 2014-07-11 at 16:53 -0500, Julian Hyde wrote:
>>> 
>>> On Jul 10, 2014, at 11:52 AM, Julian Hyde <julianhyde at gmail.com> wrote:
>>> 
>>> > On Jul 10, 2014, at 11:32 AM, Kurtis Walker <kwalker at pentaho.com> wrote:
>>> > 
>>> >> I pulled this down locally to try it out.  The ant test target has 6 more failures compared to current lagunitas branch.  I haven't investigated them all, but they look to be all around file resource paths.  Also tried the mvn test target.  It resulted in 55 failures and 33 errors.  I haven't done any investigation into those.  I'll try to keep hacking at this in my spare cycles.
>>> > 
>>> > Thanks. I’m working on some fixes.
>>> 
>>> Kurt,
>>> 
>>> I've fixed the tests. Now the suite gets the same failures via "ant test" and "maven test".
>>> 
>>> When you have a moment, can you pull the latest https://github.com/pentaho/mondrian/pull/358 and give it another try?
>>> 
>>> Julian
>> 
>> 
>> 
>> 
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.pentaho.org/pipermail/mondrian/attachments/20140714/35ce028b/attachment.html 


More information about the Mondrian mailing list