[Mondrian] Ordering of null keys

[Julian Hyde]

On Apr 21, 2014, at 8:53 AM, Matt Campbell <mcampbell at pentaho.com> wrote:

> 
> In tracking down 3 or 4 long standing test failures in lagunitas, I've noticed that members with null values for a sort key are ordered incorrectly in some cases.  That is, the #null member is sorted last, whereas I believe it should be sorted first.  I tracked this down to a deprecated block in SqlMemberSource.getMemberChildren2 (line 1191) which is currently never executed, but formerly would have moved these members to the start of the list.  I'm assuming this logic was deprecated because it doesn't handle compound keys.
> 
> My thought at a simple fix is to just check whether all keyValues are null, and if so invoke the same method to move the member.  Let me know if that would be missing something.

Sounds fine to me.

Julian