[Mondrian] RowsetDefinition.java - possible minor bug

Julian Hyde jhyde at pentaho.com
Sun May 22 15:19:42 EDT 2011

Fair enough. I had forgotten that the XMLA server now needs to run on
3rd-party olap4j drivers. It is unreasonable to expect them to make
Member.toString() equivalent to getUniqueName().
Fixed in change 14308. I also checked for other violations; there are none.
PS I am (at last) reviewing/reworking your patch for authentication. I have
quite a few comments already. It will take another couple of days.


From: Michele Rossi [mailto:michele.rossi at gmail.com] 
Sent: Saturday, May 21, 2011 2:09 AM
To: jhyde at pentaho.com; Mondrian developer mailing list
Cc: Mondrian developer mailing list
Subject: Re: [Mondrian] RowsetDefinition.java - possible minor bug

my implementation of Member didn't have toString() returning

In general I think such constraint is hard to enforce.

And this affects the xmla support which relies solely on olap4j.

So I think many similar situations will start to be flagged as people plug
their own olap4j implementations into the xmla servlet.


Sent from my iPhone

On 21 May 2011, at 01:47, Julian Hyde <jhyde at pentaho.com> wrote:

Generally Member.toString() is equivalent to getUniqueName(). If there are
any subclasses where this is not the case, let me know. Otherwise I don't
consider this a bug.


From: mondrian-bounces at pentaho.org [mailto:mondrian-bounces at pentaho.org] On
Behalf Of Michele Rossi
Sent: Friday, May 20, 2011 10:18 AM
To: Mondrian developer mailing list
Subject: [Mondrian] RowsetDefinition.java - possible minor bug

if you look at line 4527 of RowsetDefinition.java
(mondrian.xmla.RowsetDefinition) you will see

row.set(DefaultMember.name, hierarchy.getDefaultMember());

which I think should be

row.set(DefaultMember.name, hierarchy.getDefaultMember().getUniqueName());

The current implementation is calling toString() on the default member so it
only works if toString() is the same as getUniqueName().


Mondrian mailing list
Mondrian at pentaho.org

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.pentaho.org/pipermail/mondrian/attachments/20110522/42eb7140/attachment.html 

More information about the Mondrian mailing list