[Mondrian] Re: Eigenbase perforce change 13968 for review

[Luc Boudreau]

Hi Julian,

That change turns out to be a fluke indeed. I will revert it. The
FileRepository didn't return the proper name of catalogs and returned the
parent datasource's name instead. I have the fix for it but need to check
some more things before I check it in. I believe that an OLAP server can, in
theory, have multiple datasources, multiple catalogs and schemas. I'm making
sure that we cover those cases correctly and I will update the test suite
accordingly.

Luc

On Sun, Dec 12, 2010 at 3:42 AM, Julian Hyde <jhyde at pentaho.com> wrote:

>
> > Julian wrote:
> >
> > > Luc wrote:
> > >
> > > http://p4web.eigenbase.org/@md=d&c=6PU@/13968?ac=10
> > >
> > > Change 13968 by lucboudreau at luc-mondrian-3.2 on 2010/12/10 09:54:28
> > >
> > >     MONDRIAN: Fixes a bug where the RowSetDefinition object
> > > was returning the catalogs names but should have tallied all
> > > of the underlying schema names instead.
> >
> > Not a bug. What XMLA calls a Data source, JDBC (and olap4j)
> > calls a Catalog. What XMLA calls a Catalog, JDBC calls a Schema.
> >
> > So, when an XMLA request asks for the catalogs in a data
> > source X, the XmlaHandler was correctly giving them all of
> > the schemas in the catalog X.
>
> I was wrong. I still think you should back out your change, but for a
> different reason. I checked the code again, and I think that XMLA and
> olap4j
> use the same terminology for schemas and catalogs. If you want a list of
> mondrian schemas, call DBSCHEMA_SCHEMATA. You have modified
> DBSCHEMA_CATALOGS to return a list of schemas, but it should really return
> catalogs.
>
> It is datasources.xml that is inconsistent. Each <DataSource> element in a
> datasources.xml file becomes an XMLA and olap4j catalog. Each <Catalog>
> element in a datasources.xml file becomes an XMLA and olap4j schema.
>
> In a given JVM, there can be multiple instances of MondrianServer, each
> with
> its own datasources.xml file. Each of these MondrianServers is an XMLA
> "data
> source".
>
> Julian
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.pentaho.org/pipermail/mondrian/attachments/20101213/44b865a2/attachment.html