[Mondrian] Support folder older MySQL versions broken by select@@sql_mode

[Julian Hyde]

When you fix it, please keep database & version logic out of the main body
of code if at all possible. This logic should be inside the MySqlDialect
class.

Julian

> -----Original Message-----
> From: mondrian-bounces at pentaho.org 
> [mailto:mondrian-bounces at pentaho.org] On Behalf Of Eric McDermid
> Sent: Monday, October 12, 2009 9:50 AM
> To: Mondrian developer mailing list
> Subject: Re: [Mondrian] Support folder older MySQL versions 
> broken by select@@sql_mode
> 
> That was my optimization.  If it broke compatibility with older  
> versions of MySQL, it was purely accidental and should be fixed.
> 
>  From the MySQL documentation, it appears sql_mode itself was  
> introduced in 3.23.41, and the ONLY_FULL_GROUP_BY option in 4.0.   
> Since the optimizations are allowed unless ONLY_FULL_GROUP_BY 
> is set,  
> then it should be trivial to change the code to always allow the  
> optimizations on versions of MySQL that don't support sql_mode (i.e.  
> prior to 3.23.41).
> 
> What version of MySQL are you using?
> 
>   -- Eric
> 
> 
> On Oct 12, 2009, at 8:57 AM, Torsten Schlabach wrote:
> 
> > Hi!
> >
> > Is this by purpose, i.e. would this be a "won't fix"?
> >
> > Or would a patch which would check for the existence of the sql_mode
> > environment variable first be considered, so Mondrian would retain
> > compatibility with a wider range of versions of MySQL?
> >
> > Background:
> >
> > 
> http://julianhyde.blogspot.com/2009/07/functional-dependency-o
> ptimizations-in.html
> >
> > That Mondrian asks MySQL for the sql_mode seems to have been  
> > introduced
> > only recently for some optimizations.
> >
> > Regards,
> > Torsten
> > _______________________________________________
> > Mondrian mailing list
> > Mondrian at pentaho.org
> > http://lists.pentaho.org/mailman/listinfo/mondrian
> >
> 
> _______________________________________________
> Mondrian mailing list
> Mondrian at pentaho.org
> http://lists.pentaho.org/mailman/listinfo/mondrian
> 
>