[Mondrian] FW: Cron <jhyde at marmalade> nice bash --login /home/jhyde/open2/mondrian/bin/megatest --nightly

Julian Hyde jhyde at pentaho.com
Mon Sep 15 03:00:38 EDT 2008


Luis,

Your last change introduced a build error (a reference to the non-existent
class MemberNoCacheHelper). Please fix asap.

compile.java:
    [javac] Compiling 519 source files to /home/jhyde/open2/mondrian/classes
    [javac]
/home/jhyde/open2/mondrian/src/main/mondrian/rolap/RolapCubeHierarchy.java:7
65: cannot find symbol
    [javac] symbol  : class MemberNoCacheHelper
    [javac] location: class
mondrian.rolap.RolapCubeHierarchy.NoCacheRolapCubeHierarchyMemberReader
    [javac]                 new MemberNoCacheHelper();
    [javac]                     ^
    [javac]
/home/jhyde/open2/mondrian/src/main/mondrian/rolap/RolapCubeHierarchy.java:7
71: cannot find symbol
    [javac] symbol  : class MemberNoCacheHelper
    [javac] location: class
mondrian.rolap.RolapCubeHierarchy.NoCacheRolapCubeHierarchyMemberReader
    [javac]                     new MemberNoCacheHelper());
    [javac]                         ^

It fixed some of the coding style violations (thanks), but left some:

./testsrc/main/mondrian/rolap/HighDimensionsTest.java: 86:
if/while/for/switch/synchronized/catch/do must be followed by space
./testsrc/main/mondrian/rolap/HighDimensionsTest.java: 89: if followed by
statement on same line
./testsrc/main/mondrian/rolap/HighDimensionsTest.java: 89:
if/while/for/switch/synchronized/catch/do must be followed by space
./testsrc/main/mondrian/rolap/HighDimensionsTest.java: 144: Line ends in
space
./testsrc/main/mondrian/rolap/HighDimensionsTest.java: 145: Line ends in
space
./testsrc/main/mondrian/rolap/HighDimensionsTest.java: 152: Line ends in
space
./testsrc/main/mondrian/rolap/HighDimensionsTest.java: 174: Line ends in
space
./testsrc/main/mondrian/rolap/HighDimensionsTest.java: 176: Line ends in
space
./testsrc/main/mondrian/rolap/HighDimensionsTest.java: 186: if followed by
statement on same line
./testsrc/main/mondrian/rolap/HighDimensionsTest.java: 190: if followed by
statement on same line
./testsrc/main/mondrian/rolap/HighDimensionsTest.java: 192: Line ends in
space
./testsrc/main/mondrian/rolap/HighDimensionsTest.java: 262: Line ends in
space
./testsrc/main/mondrian/rolap/HighDimensionsTest.java: 373: Line ends in
space
./testsrc/main/mondrian/rolap/HighDimensionsTest.java: 376: Line ends in
space
./testsrc/main/mondrian/rolap/HighDimensionsTest.java: 384: Line ends in
space
./testsrc/main/mondrian/rolap/HighDimensionsTest.java: 391: Line ends in
space

By the way, the coding standard is to treat assert like an operator, not a
function. For example:

assert (x > 0); // WRONG (parentheses not necessary)
assert x > 0; // RIGHT
assert(x > 0 || y < 0) && z != null; // WRONG (no space before paren)
assert (x > 0 || y < 0) && z != null; // RIGHT

Julian





More information about the Mondrian mailing list