[Mondrian] Aggregation.flush code review

Julian Hyde julianhyde at speakeasy.net
Thu Apr 5 03:17:05 EDT 2007


Yes. You could either short-circuit the loop or not bother computing
bitmapsIntersect. The latter is simpler, so gets my vote.

> -----Original Message-----
> From: mondrian-bounces at pentaho.org 
> [mailto:mondrian-bounces at pentaho.org] On Behalf Of Richard Emberson
> Sent: Wednesday, April 04, 2007 1:41 PM
> To: Mondrian developer mailing list
> Subject: Re: [Mondrian] Aggregation.flush code review
> 
> Added "enter the"
> 
> Richard Emberson wrote:
> > 
> > It would seem that in the Aggregation
> > flush(CacheControl,RolapCacheRegion) method, if
> > boolean bitmapsIntersect is false, then
> > there is no need to enter the segmentLoop for loop since
> > 
> >             if (!bitmapsIntersect) {
> >                 continue;
> >             }
> > 
> > always executes.
> > 
> > Yes?
> > 
> > 
> > Richard
> > 
> > 
> > -- 
> > Quis custodiet ipsos custodes:
> > This email message is for the sole use of the intended 
> recipient(s) and
> > may contain confidential information.  Any unauthorized review, use,
> > disclosure or distribution is prohibited.  If you are not 
> the intended
> > recipient, please contact the sender by reply email and destroy all
> > copies of the original message.
> > _______________________________________________
> > Mondrian mailing list
> > Mondrian at pentaho.org
> > http://lists.pentaho.org/mailman/listinfo/mondrian
> > 
> 
> 
> -- 
> Quis custodiet ipsos custodes:
> This email message is for the sole use of the intended 
> recipient(s) and
> may contain confidential information.  Any unauthorized review, use,
> disclosure or distribution is prohibited.  If you are not the intended
> recipient, please contact the sender by reply email and destroy all
> copies of the original message.
> _______________________________________________
> Mondrian mailing list
> Mondrian at pentaho.org
> http://lists.pentaho.org/mailman/listinfo/mondrian
> 




More information about the Mondrian mailing list