<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 TRANSITIONAL//EN">
<HTML>
<HEAD>
<META HTTP-EQUIV="Content-Type" CONTENT="text/html; CHARSET=UTF-8">
<META NAME="GENERATOR" CONTENT="GtkHTML/4.6.6">
</HEAD>
<BODY>
I had to make another change to get all expected tests to pass. <A HREF="https://github.com/kurtwalker/mondrian/commit/42d2b55fa0daac4041b5941bf223368868a6a381">https://github.com/kurtwalker/mondrian/commit/42d2b55fa0daac4041b5941bf223368868a6a381</A><BR>
<BR>
Any objection to squashing all these into a single commit?<BR>
<BR>
Kurt<BR>
On Sat, 2014-07-12 at 23:48 -0500, Julian Hyde wrote:
<BLOCKQUOTE TYPE=CITE>
Strange. I get 13 failures, 0 errors on lagunitas [1], and 12 failures, 0 errors on maven2 [2]. (One fewer failure because I fixed testCodeFormatting.)
</BLOCKQUOTE>
<BLOCKQUOTE TYPE=CITE>
<BR>
<BR>
</BLOCKQUOTE>
<BLOCKQUOTE TYPE=CITE>
.csv files now live under src/test/resources rather than testsrc/main. Maven copies them to target/test-classes, and the tests (e.g. RolapResultTest) look for them there. Maybe you're running 'ant test' but have not run 'mvn compile' or similar to copy them.
</BLOCKQUOTE>
<BLOCKQUOTE TYPE=CITE>
<BR>
<BR>
</BLOCKQUOTE>
<BLOCKQUOTE TYPE=CITE>
In my opinion, it's OK if that scenario doesn't work. If you run 'mvn compile' first, I think you'll find that maven2 is at parity with lagunitas.
</BLOCKQUOTE>
<BLOCKQUOTE TYPE=CITE>
<BR>
<BR>
</BLOCKQUOTE>
<BLOCKQUOTE TYPE=CITE>
Julian
</BLOCKQUOTE>
<BLOCKQUOTE TYPE=CITE>
<BR>
<BR>
</BLOCKQUOTE>
<BLOCKQUOTE TYPE=CITE>
[1] <A HREF="https://github.com/julianhyde/mondrian/commit/53bb59393ad5c116d3a1b4e8f4ce8d76698f8c8a">https://github.com/julianhyde/mondrian/commit/53bb59393ad5c116d3a1b4e8f4ce8d76698f8c8a</A>
</BLOCKQUOTE>
<BLOCKQUOTE TYPE=CITE>
[2] <A HREF="https://github.com/julianhyde/mondrian/commit/69d5d7097165ea66f306a5d5e96613f77998a95f">https://github.com/julianhyde/mondrian/commit/69d5d7097165ea66f306a5d5e96613f77998a95f</A>
</BLOCKQUOTE>
<BLOCKQUOTE TYPE=CITE>
<BR>
<BR>
</BLOCKQUOTE>
<BLOCKQUOTE TYPE=CITE>
On Sat, Jul 12, 2014 at 2:52 PM, Kurtis Walker <<A HREF="mailto:kwalker@pentaho.com">kwalker@pentaho.com</A>> wrote:
</BLOCKQUOTE>
<BLOCKQUOTE TYPE=CITE>
<BLOCKQUOTE>
yup, ant and mvn both have the same test results. But, there are still six more failures compared to lagunitas. All FileNotFoundException. I think some csv resources are not getting included in the compile.
</BLOCKQUOTE>
</BLOCKQUOTE>
<BLOCKQUOTE TYPE=CITE>
<BLOCKQUOTE>
<BR>
<BR>
On Fri, 2014-07-11 at 16:53 -0500, Julian Hyde wrote:
<BLOCKQUOTE TYPE=CITE>
<PRE>
On Jul 10, 2014, at 11:52 AM, Julian Hyde <<A HREF="mailto:julianhyde@gmail.com">julianhyde@gmail.com</A>> wrote:
<FONT COLOR="#737373">> On Jul 10, 2014, at 11:32 AM, Kurtis Walker <<A HREF="mailto:kwalker@pentaho.com">kwalker@pentaho.com</A>> wrote:</FONT>
<FONT COLOR="#737373">> </FONT>
<FONT COLOR="#737373">>> I pulled this down locally to try it out. The ant test target has 6 more failures compared to current lagunitas branch. I haven't investigated them all, but they look to be all around file resource paths. Also tried the mvn test target. It resulted in 55 failures and 33 errors. I haven't done any investigation into those. I'll try to keep hacking at this in my spare cycles.</FONT>
<FONT COLOR="#737373">> </FONT>
<FONT COLOR="#737373">> Thanks. I’m working on some fixes.</FONT>
Kurt,
I've fixed the tests. Now the suite gets the same failures via "ant test" and "maven test".
When you have a moment, can you pull the latest <A HREF="https://github.com/pentaho/mondrian/pull/358">https://github.com/pentaho/mondrian/pull/358</A> and give it another try?
Julian
</PRE>
</BLOCKQUOTE>
<BR>
<BR>
</BLOCKQUOTE>
</BLOCKQUOTE>
<BLOCKQUOTE TYPE=CITE>
<BR>
<BR>
</BLOCKQUOTE>
<BR>
</BODY>
</HTML>