<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN">
<HTML><HEAD>
<META content="text/html; charset=us-ascii" http-equiv=Content-Type>
<META name=GENERATOR content="MSHTML 9.00.8112.16421"></HEAD>
<BODY bgColor=#ffffff>
<DIV><SPAN class=674261019-22052011><FONT color=#000080 size=2
face="Lucida Sans">Fair enough. I had forgotten that the XMLA server now needs
to run on 3rd-party olap4j drivers. It is unreasonable to expect them to make
Member.toString() equivalent to getUniqueName().</FONT></SPAN></DIV>
<DIV><SPAN class=674261019-22052011><FONT color=#000080 size=2
face="Lucida Sans"></FONT></SPAN> </DIV>
<DIV><SPAN class=674261019-22052011><FONT color=#000080 size=2
face="Lucida Sans">Fixed in change 14308. I also checked for other violations;
there are none.</FONT></SPAN></DIV>
<DIV><SPAN class=674261019-22052011><FONT color=#000080 size=2
face="Lucida Sans"></FONT></SPAN> </DIV>
<DIV><SPAN class=674261019-22052011><FONT color=#000080 size=2
face="Lucida Sans">Julian</FONT></SPAN></DIV>
<DIV><SPAN class=674261019-22052011><FONT color=#000080 size=2
face="Lucida Sans"></FONT></SPAN> </DIV>
<DIV><SPAN class=674261019-22052011><FONT color=#000080 size=2
face="Lucida Sans">PS I am (at last) reviewing/reworking your patch for
authentication. I have quite a few comments already. It will take another couple
of days.</FONT></SPAN></DIV><BR>
<BLOCKQUOTE
style="BORDER-LEFT: #000080 2px solid; PADDING-LEFT: 5px; MARGIN-LEFT: 5px; MARGIN-RIGHT: 0px"
dir=ltr>
<DIV dir=ltr lang=en-us class=OutlookMessageHeader align=left>
<HR tabIndex=-1>
<FONT size=2 face=Tahoma><B>From:</B> Michele Rossi
[mailto:michele.rossi@gmail.com] <BR><B>Sent:</B> Saturday, May 21, 2011 2:09
AM<BR><B>To:</B> jhyde@pentaho.com; Mondrian developer mailing
list<BR><B>Cc:</B> Mondrian developer mailing list<BR><B>Subject:</B> Re:
[Mondrian] RowsetDefinition.java - possible minor bug<BR></FONT><BR></DIV>
<DIV></DIV>
<DIV>hi,</DIV>
<DIV>my implementation of Member didn't have toString() returning
getUniqueName(). </DIV>
<DIV><BR></DIV>
<DIV>In general I think such constraint is hard to enforce.</DIV>
<DIV><BR></DIV>
<DIV>And this affects the xmla support which relies solely on olap4j.</DIV>
<DIV><BR></DIV>
<DIV>So I think many similar situations will start to be flagged as people
plug their own olap4j implementations into the xmla servlet.</DIV>
<DIV><BR></DIV>
<DIV>Thanks,</DIV>
<DIV>Michele<BR><BR>Sent from my iPhone</DIV>
<DIV><BR>On 21 May 2011, at 01:47, Julian Hyde <<A
href="mailto:jhyde@pentaho.com">jhyde@pentaho.com</A>> wrote:<BR><BR></DIV>
<DIV></DIV>
<BLOCKQUOTE type="cite">
<DIV>
<DIV><SPAN class=109174523-20052011><FONT color=#000080 size=2
face="Lucida Sans">Generally Member.toString() is equivalent to
getUniqueName(). If there are any subclasses where this is not the case, let
me know. Otherwise I don't consider this a bug.</FONT></SPAN></DIV>
<DIV><SPAN class=109174523-20052011><FONT color=#000080 size=2
face="Lucida Sans"></FONT></SPAN> </DIV>
<DIV><SPAN class=109174523-20052011><FONT color=#000080 size=2
face="Lucida Sans">Julian</FONT></SPAN></DIV><BR>
<BLOCKQUOTE
style="BORDER-LEFT: #000080 2px solid; PADDING-LEFT: 5px; MARGIN-LEFT: 5px; MARGIN-RIGHT: 0px"
dir=ltr>
<DIV dir=ltr lang=en-us class=OutlookMessageHeader align=left>
<HR tabIndex=-1>
<FONT size=2 face=Tahoma><B>From:</B> <A
href="mailto:mondrian-bounces@pentaho.org">mondrian-bounces@pentaho.org</A>
[mailto:mondrian-bounces@pentaho.org] <B>On Behalf Of </B>Michele
Rossi<BR><B>Sent:</B> Friday, May 20, 2011 10:18 AM<BR><B>To:</B> Mondrian
developer mailing list<BR><B>Subject:</B> [Mondrian] RowsetDefinition.java
- possible minor bug<BR></FONT><BR></DIV>
<DIV></DIV>Hi,
<DIV>if you look at line 4527 of RowsetDefinition.java
(mondrian.xmla.RowsetDefinition) you will see</DIV>
<DIV><BR></DIV>
<DIV><BR></DIV>
<DIV>row.set(DefaultMember.name, hierarchy.getDefaultMember());</DIV>
<DIV><BR></DIV>
<DIV>which I think should be</DIV>
<DIV><BR></DIV>
<DIV>row.set(DefaultMember.name,
hierarchy.getDefaultMember().getUniqueName());</DIV>
<DIV><BR></DIV>
<DIV>The current implementation is calling toString() on the default
member so it only works if toString() is the same as
getUniqueName().</DIV>
<DIV><BR></DIV>
<DIV>thanks,</DIV>
<DIV>Michele</DIV></BLOCKQUOTE></DIV></BLOCKQUOTE>
<BLOCKQUOTE type="cite">
<DIV><SPAN>_______________________________________________</SPAN><BR><SPAN>Mondrian
mailing list</SPAN><BR><SPAN><A
href="mailto:Mondrian@pentaho.org">Mondrian@pentaho.org</A></SPAN><BR><SPAN><A
href="http://lists.pentaho.org/mailman/listinfo/mondrian">http://lists.pentaho.org/mailman/listinfo/mondrian</A></SPAN><BR></DIV></BLOCKQUOTE></BLOCKQUOTE></BODY></HTML>