Yeah, I saw that after I checked it in. What I'll do is the same approach as the SQL pattern detection tests. I want to extend the XML ref logs and add an attribute to tell which response XML corresponds to which test context database dialect. This way we won't have to bend the code in order to support the test cases. You said that the original design was to avoid having multiple ref logs, what about having something like:<br>
<br><span style="font-family: courier new,monospace;"><test><br> (...)<br> <response dialect="default"></span><br style="font-family: courier new,monospace;"><span style="font-family: courier new,monospace;"> (...)</span><br style="font-family: courier new,monospace;">
<span style="font-family: courier new,monospace;"> </response></span><br style="font-family: courier new,monospace;"><span style="font-family: courier new,monospace;"> <response dialect="oracle"></span><br style="font-family: courier new,monospace;">
<span style="font-family: courier new,monospace;">
(...)</span><br style="font-family: courier new,monospace;"><span style="font-family: courier new,monospace;"> </response></span><br><span style="font-family: courier new,monospace;"></test></span><br clear="all">
<br>
<br><br><div class="gmail_quote">On Tue, Nov 16, 2010 at 5:20 PM, Julian Hyde <span dir="ltr"><<a href="mailto:jhyde@pentaho.com">jhyde@pentaho.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
> Luc Boudreau wrote:<br>
><br>
> <a href="http://p4web.eigenbase.org/@md=d&c=6PU@/13913?ac=10" target="_blank">http://p4web.eigenbase.org/@md=d&c=6PU@/13913?ac=10</a><br>
><br>
> Change 13913 by lucboudreau@luc-mondrian-3.2 on 2010/11/16 06:48:42<br>
><br>
> MONDRIAN-613 Missing xsd:type attribute in drill-down<br>
> rowset makes Excel 2007 crash. Also, when returning a<br>
> drillthrough query result, use the actual DB specified type<br>
> for the row set XSD infos rather than the schema infos.<br>
<br>
Luc,<br>
<br>
The trouble with inferring the XML type from the database type is that the<br>
database type is different for every database. So, your change has broken<br>
the drillthrough tests in XmlaBasicTest on oracle. The previous behavior was<br>
mostly a matter of expediency, to avoid maintaining multiple ref logs, one<br>
for each database.<br>
<br>
Any ideas how to fix this?<br>
<br>
As it happens I'm working on XMLA drillthrough support right now, so the<br>
test exceptions had me mighty puzzled for a while.<br>
<font color="#888888"><br>
Julian<br>
<br>
</font></blockquote></div><br>