<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 TRANSITIONAL//EN">
<HTML>
<HEAD>
<META HTTP-EQUIV="Content-Type" CONTENT="text/html; CHARSET=UTF-8">
<META NAME="GENERATOR" CONTENT="GtkHTML/3.18.3">
</HEAD>
<BODY>
Will,<BR>
<BR>
Thanks for fixing this. But I fear that it is a poorly documented half-fix.<BR>
<BR>
Someone reading that wouldn't know what was going on. I know now - having read a few email messages - that dist and dev have different directory structures, but a maintainer would not, just from reading that code. In fact it was my ignorance of that matter which caused this bug in the first place.<BR>
<BR>
As a best practice, a script should figure out its environment from $0 (the path of the script) and not from the caller's location. This script does that for dev mode but not dist mode. For this to work in this script, the script should first figure out whether it is in a dist or dev environment. Maybe it can look for $(dirname $0)/lib?<BR>
<BR>
Julian<BR>
<BR>
On Thu, 2008-10-30 at 15:20 -0700, Will Gorman wrote:
<BLOCKQUOTE TYPE=CITE>
<PRE>
<A HREF="http://p4web.eigenbase.org/@md=d&c=6PU@//11856?ac=10">http://p4web.eigenbase.org/@md=d&c=6PU@//11856?ac=10</A>
Change 11856 by <A HREF="mailto:wgorman@guest.willgorman.pentaho">wgorman@guest.willgorman.pentaho</A> on 2008/10/30 15:18:41
MONDRIAN: fixed workbench.sh in dist mode
Affected files ...
... //open/mondrian/workbench/workbench.sh#7 edit
Differences ...
==== //open/mondrian/workbench/workbench.sh#7 (kxtext) ====
2c2
< # $Id: //open/mondrian/workbench/workbench.sh#6 $
---
> # $Id: //open/mondrian/workbench/workbench.sh#7 $
6a7,9
> if test ! -d $MONDRIAN_HOME/lib; then
> MONDRIAN_HOME=$(pwd)
> fi
</PRE>
</BLOCKQUOTE>
</BODY>
</HTML>