<html><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">Hi Julian,<div><br></div><div>p4 didn't add correctly the new class, even when it claims me everything's ok!</div><div>Now it's fixed: getting a clear copy of repository and adding again.</div><div><br></div><div>Please, how can I test code conventions locally, without commiting changes and waiting for notifications?</div><div><br></div><div>Thanks a lot, Julian.</div><div><br></div><div>- Luis F. Canals</div><div><div apple-content-edited="true"><span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Arial; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0; "><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><div>&nbsp;&nbsp;CISM</div><div>&nbsp;&nbsp;<a href="mailto:luis.canals@stratebi.com">luis.canals@stratebi.com</a></div><div><br></div></div></span><br class="Apple-interchange-newline"> </div><br><div><div>On 15/09/2008, at 9:00, Julian Hyde wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite">Luis,<br><br>Your last change introduced a build error (a reference to the non-existent<br>class MemberNoCacheHelper). Please fix asap.<br><br>compile.java:<br> &nbsp;&nbsp;&nbsp;[javac] Compiling 519 source files to /home/jhyde/open2/mondrian/classes<br> &nbsp;&nbsp;&nbsp;[javac]<br>/home/jhyde/open2/mondrian/src/main/mondrian/rolap/RolapCubeHierarchy.java:7<br>65: cannot find symbol<br> &nbsp;&nbsp;&nbsp;[javac] symbol &nbsp;: class MemberNoCacheHelper<br> &nbsp;&nbsp;&nbsp;[javac] location: class<br>mondrian.rolap.RolapCubeHierarchy.NoCacheRolapCubeHierarchyMemberReader<br> &nbsp;&nbsp;&nbsp;[javac] &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;new MemberNoCacheHelper();<br> &nbsp;&nbsp;&nbsp;[javac] &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;^<br> &nbsp;&nbsp;&nbsp;[javac]<br>/home/jhyde/open2/mondrian/src/main/mondrian/rolap/RolapCubeHierarchy.java:7<br>71: cannot find symbol<br> &nbsp;&nbsp;&nbsp;[javac] symbol &nbsp;: class MemberNoCacheHelper<br> &nbsp;&nbsp;&nbsp;[javac] location: class<br>mondrian.rolap.RolapCubeHierarchy.NoCacheRolapCubeHierarchyMemberReader<br> &nbsp;&nbsp;&nbsp;[javac] &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;new MemberNoCacheHelper());<br> &nbsp;&nbsp;&nbsp;[javac] &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;^<br><br>It fixed some of the coding style violations (thanks), but left some:<br><br>./testsrc/main/mondrian/rolap/HighDimensionsTest.java: 86:<br>if/while/for/switch/synchronized/catch/do must be followed by space<br>./testsrc/main/mondrian/rolap/HighDimensionsTest.java: 89: if followed by<br>statement on same line<br>./testsrc/main/mondrian/rolap/HighDimensionsTest.java: 89:<br>if/while/for/switch/synchronized/catch/do must be followed by space<br>./testsrc/main/mondrian/rolap/HighDimensionsTest.java: 144: Line ends in<br>space<br>./testsrc/main/mondrian/rolap/HighDimensionsTest.java: 145: Line ends in<br>space<br>./testsrc/main/mondrian/rolap/HighDimensionsTest.java: 152: Line ends in<br>space<br>./testsrc/main/mondrian/rolap/HighDimensionsTest.java: 174: Line ends in<br>space<br>./testsrc/main/mondrian/rolap/HighDimensionsTest.java: 176: Line ends in<br>space<br>./testsrc/main/mondrian/rolap/HighDimensionsTest.java: 186: if followed by<br>statement on same line<br>./testsrc/main/mondrian/rolap/HighDimensionsTest.java: 190: if followed by<br>statement on same line<br>./testsrc/main/mondrian/rolap/HighDimensionsTest.java: 192: Line ends in<br>space<br>./testsrc/main/mondrian/rolap/HighDimensionsTest.java: 262: Line ends in<br>space<br>./testsrc/main/mondrian/rolap/HighDimensionsTest.java: 373: Line ends in<br>space<br>./testsrc/main/mondrian/rolap/HighDimensionsTest.java: 376: Line ends in<br>space<br>./testsrc/main/mondrian/rolap/HighDimensionsTest.java: 384: Line ends in<br>space<br>./testsrc/main/mondrian/rolap/HighDimensionsTest.java: 391: Line ends in<br>space<br><br>By the way, the coding standard is to treat assert like an operator, not a<br>function. For example:<br><br>assert (x > 0); // WRONG (parentheses not necessary)<br>assert x > 0; // RIGHT<br>assert(x > 0 || y &lt; 0) &amp;&amp; z != null; // WRONG (no space before paren)<br>assert (x > 0 || y &lt; 0) &amp;&amp; z != null; // RIGHT<br><br>Julian<br><br></blockquote></div><br></div></body></html>