<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN">
<HTML><HEAD>
<META http-equiv=Content-Type content="text/html; charset=us-ascii">
<META content="MSHTML 6.00.6001.18099" name=GENERATOR></HEAD>
<BODY
style="WORD-WRAP: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space">
<DIV dir=ltr align=left><SPAN class=339024516-15092008><FONT face=Verdana
color=#000080 size=2>Use the script //open/util/bin/checkFile. It is a bash
script, so requires Unix/Linux/Cygwin. Put it on your path and type 'checkFile
--opened' and it will check all files that you have open for
edit.</FONT></SPAN></DIV>
<DIV dir=ltr align=left><SPAN class=339024516-15092008><FONT face=Verdana
color=#000080 size=2></FONT></SPAN> </DIV>
<DIV dir=ltr align=left><SPAN class=339024516-15092008><FONT face=Verdana
color=#000080 size=2>Julian</FONT></SPAN></DIV><BR>
<BLOCKQUOTE dir=ltr
style="PADDING-LEFT: 5px; MARGIN-LEFT: 5px; BORDER-LEFT: #000080 2px solid; MARGIN-RIGHT: 0px">
<DIV class=OutlookMessageHeader lang=en-us dir=ltr align=left>
<HR tabIndex=-1>
<FONT face=Tahoma size=2><B>From:</B> Luis F. Canals
[mailto:luisf.canals@gmail.com] <B>On Behalf Of </B>Luis F.
Canals<BR><B>Sent:</B> Monday, September 15, 2008 1:31 AM<BR><B>To:</B>
jhyde@pentaho.com<BR><B>Cc:</B> mondrian@pentaho.org<BR><B>Subject:</B> Re:
Cron <jhyde@marmalade> nice bash --login
/home/jhyde/open2/mondrian/bin/megatest --nightly<BR></FONT><BR></DIV>
<DIV></DIV>Hi Julian,
<DIV><BR></DIV>
<DIV>p4 didn't add correctly the new class, even when it claims me
everything's ok!</DIV>
<DIV>Now it's fixed: getting a clear copy of repository and adding
again.</DIV>
<DIV><BR></DIV>
<DIV>Please, how can I test code conventions locally, without commiting
changes and waiting for notifications?</DIV>
<DIV><BR></DIV>
<DIV>Thanks a lot, Julian.</DIV>
<DIV><BR></DIV>
<DIV>- Luis F. Canals</DIV>
<DIV>
<DIV apple-content-edited="true"><SPAN class=Apple-style-span
style="WORD-SPACING: 0px; FONT: 12px Arial; TEXT-TRANSFORM: none; COLOR: rgb(0,0,0); TEXT-INDENT: 0px; WHITE-SPACE: normal; LETTER-SPACING: normal; BORDER-COLLAPSE: separate; orphans: 2; widows: 2; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0">
<DIV
style="WORD-WRAP: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space">
<DIV> CISM</DIV>
<DIV> <A
href="mailto:luis.canals@stratebi.com">luis.canals@stratebi.com</A></DIV>
<DIV><BR></DIV></DIV></SPAN><BR class=Apple-interchange-newline></DIV><BR>
<DIV>
<DIV>On 15/09/2008, at 9:00, Julian Hyde wrote:</DIV><BR
class=Apple-interchange-newline>
<BLOCKQUOTE type="cite">Luis,<BR><BR>Your last change introduced a build
error (a reference to the non-existent<BR>class MemberNoCacheHelper). Please
fix asap.<BR><BR>compile.java:<BR> [javac] Compiling 519
source files to
/home/jhyde/open2/mondrian/classes<BR> [javac]<BR>/home/jhyde/open2/mondrian/src/main/mondrian/rolap/RolapCubeHierarchy.java:7<BR>65:
cannot find symbol<BR> [javac] symbol : class
MemberNoCacheHelper<BR> [javac] location:
class<BR>mondrian.rolap.RolapCubeHierarchy.NoCacheRolapCubeHierarchyMemberReader<BR> [javac]
new
MemberNoCacheHelper();<BR> [javac]
^<BR> [javac]<BR>/home/jhyde/open2/mondrian/src/main/mondrian/rolap/RolapCubeHierarchy.java:7<BR>71:
cannot find symbol<BR> [javac] symbol : class
MemberNoCacheHelper<BR> [javac] location:
class<BR>mondrian.rolap.RolapCubeHierarchy.NoCacheRolapCubeHierarchyMemberReader<BR> [javac]
new
MemberNoCacheHelper());<BR> [javac]
^<BR><BR>It
fixed some of the coding style violations (thanks), but left
some:<BR><BR>./testsrc/main/mondrian/rolap/HighDimensionsTest.java:
86:<BR>if/while/for/switch/synchronized/catch/do must be followed by
space<BR>./testsrc/main/mondrian/rolap/HighDimensionsTest.java: 89: if
followed by<BR>statement on same
line<BR>./testsrc/main/mondrian/rolap/HighDimensionsTest.java:
89:<BR>if/while/for/switch/synchronized/catch/do must be followed by
space<BR>./testsrc/main/mondrian/rolap/HighDimensionsTest.java: 144: Line
ends in<BR>space<BR>./testsrc/main/mondrian/rolap/HighDimensionsTest.java:
145: Line ends
in<BR>space<BR>./testsrc/main/mondrian/rolap/HighDimensionsTest.java: 152:
Line ends
in<BR>space<BR>./testsrc/main/mondrian/rolap/HighDimensionsTest.java: 174:
Line ends
in<BR>space<BR>./testsrc/main/mondrian/rolap/HighDimensionsTest.java: 176:
Line ends
in<BR>space<BR>./testsrc/main/mondrian/rolap/HighDimensionsTest.java: 186:
if followed by<BR>statement on same
line<BR>./testsrc/main/mondrian/rolap/HighDimensionsTest.java: 190: if
followed by<BR>statement on same
line<BR>./testsrc/main/mondrian/rolap/HighDimensionsTest.java: 192: Line
ends in<BR>space<BR>./testsrc/main/mondrian/rolap/HighDimensionsTest.java:
262: Line ends
in<BR>space<BR>./testsrc/main/mondrian/rolap/HighDimensionsTest.java: 373:
Line ends
in<BR>space<BR>./testsrc/main/mondrian/rolap/HighDimensionsTest.java: 376:
Line ends
in<BR>space<BR>./testsrc/main/mondrian/rolap/HighDimensionsTest.java: 384:
Line ends
in<BR>space<BR>./testsrc/main/mondrian/rolap/HighDimensionsTest.java: 391:
Line ends in<BR>space<BR><BR>By the way, the coding standard is to treat
assert like an operator, not a<BR>function. For example:<BR><BR>assert (x
> 0); // WRONG (parentheses not necessary)<BR>assert x > 0; //
RIGHT<BR>assert(x > 0 || y < 0) && z != null; // WRONG (no
space before paren)<BR>assert (x > 0 || y < 0) && z != null;
//
RIGHT<BR><BR>Julian<BR><BR></BLOCKQUOTE></DIV><BR></DIV></BLOCKQUOTE></BODY></HTML>