<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 TRANSITIONAL//EN">
<HTML>
<HEAD>
<META HTTP-EQUIV="Content-Type" CONTENT="text/html; CHARSET=UTF-8">
<META NAME="GENERATOR" CONTENT="GtkHTML/3.18.3">
</HEAD>
<BODY>
Rushan,<BR>
<BR>
Your recent change 11499 has a bunch of coding style violations as detected by the //open/util/bin/checkFile utility. Normally a perforce trigger would detect these violations, but we deliberately do not prevent check-ins during integration -- it would make integrations unfeasibly difficult. Can please you fix the files now?<BR>
<BR>
Run<BR>
<BR>
find mondrian -type f | xargs util/bin/checkFile<BR>
<BR>
and you will see the list. If you use emacs, you may find it convenient to paste the output into emacs *Compilation* buffer.<BR>
<BR>
Other than these exceptions, all code on the //open/mondrian branch is clean. I recommend that you integrate the formatting fixes to your branch asap, to prevent future merging difficulties. In future, please run checkFile on your branch BEFORE integrating so that the main line stays clean.<BR>
<BR>
Julian
</BODY>
</HTML>