<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN">
<HTML><HEAD>
<META http-equiv=Content-Type content="text/html; charset=us-ascii">
<META content="MSHTML 6.00.6000.16546" name=GENERATOR></HEAD>
<BODY>
<DIV dir=ltr align=left><SPAN class=566483618-06112007><FONT face=Verdana
color=#000080 size=2>Ajit,</FONT></SPAN></DIV>
<DIV dir=ltr align=left><SPAN class=566483618-06112007><FONT face=Verdana
color=#000080 size=2></FONT></SPAN> </DIV>
<DIV dir=ltr align=left><SPAN class=566483618-06112007><FONT face=Verdana
color=#000080 size=2>Your change looks good. Excellent work -
thanks.</FONT></SPAN></DIV>
<DIV dir=ltr align=left><SPAN class=566483618-06112007><FONT face=Verdana
color=#000080 size=2></FONT></SPAN> </DIV>
<DIV dir=ltr align=left><SPAN class=566483618-06112007><FONT face=Verdana
color=#000080 size=2>Julian</FONT> </SPAN></DIV><BR>
<BLOCKQUOTE
style="PADDING-LEFT: 5px; MARGIN-LEFT: 5px; BORDER-LEFT: #000080 2px solid; MARGIN-RIGHT: 0px">
<DIV class=OutlookMessageHeader lang=en-us dir=ltr align=left>
<HR tabIndex=-1>
<FONT face=Tahoma size=2><B>From:</B> mondrian-bounces@pentaho.org
[mailto:mondrian-bounces@pentaho.org] <B>On Behalf Of </B>Ajit Vasudeo
Joglekar<BR><B>Sent:</B> Tuesday, November 06, 2007 9:33 AM<BR><B>To:</B>
julian@hydromatic.net<BR><B>Cc:</B> mondrian@pentaho.org<BR><B>Subject:</B>
[Mondrian] RE: Eigenbase perforce change 10142 for review<BR></FONT><BR></DIV>
<DIV></DIV><BR><FONT face=sans-serif size=2>Thanks Julian,</FONT>
<BR><BR><FONT face=sans-serif size=2>I have made the test strategy
changes</FONT> <BR><BR><FONT face=sans-serif size=2>I have added three
specific test cases for different NullMemberRepresentation values in megatest
doAllTests()</FONT> <BR><BR><FONT face=sans-serif size=2>The tests that would
have failed now recuse themselves whenever the NullMemberRepresentation value
is other than default. Other possibility was to form the expected result
values using the current NullMemberRepresentation value atleast in the case of
non xml file based tests</FONT> <BR><BR><FONT face=sans-serif
size=2>-Ajit</FONT> <BR><BR><BR><BR><BR>
<TABLE width="100%">
<TBODY>
<TR vAlign=top>
<TD width="40%"><FONT face=sans-serif size=1><B>"Julian Hyde"
<jhyde@pentaho.org></B> </FONT>
<P><FONT face=sans-serif size=1>11/04/2007 07:49 AM</FONT>
<TABLE border=1>
<TBODY>
<TR vAlign=top>
<TD bgColor=white>
<DIV align=center><FONT face=sans-serif size=1>Please respond
to<BR><julian@hydromatic.net></FONT></DIV></TR></TBODY></TABLE><BR></P>
<TD width="59%">
<TABLE width="100%">
<TBODY>
<TR vAlign=top>
<TD>
<DIV align=right><FONT face=sans-serif size=1>To</FONT></DIV>
<TD><FONT face=sans-serif size=1>"'Ajit Joglekar'"
<ajogleka@thoughtworks.com></FONT>
<TR vAlign=top>
<TD>
<DIV align=right><FONT face=sans-serif size=1>cc</FONT></DIV>
<TD><FONT face=sans-serif
size=1><mondrian@pentaho.org></FONT>
<TR vAlign=top>
<TD>
<DIV align=right><FONT face=sans-serif size=1>Subject</FONT></DIV>
<TD><FONT face=sans-serif size=1>RE: Eigenbase perforce change
10142 for review</FONT></TR></TBODY></TABLE><BR>
<TABLE>
<TBODY>
<TR vAlign=top>
<TD>
<TD></TR></TBODY></TABLE><BR></TR></TBODY></TABLE><BR><BR><BR><FONT
size=2><TT>Ajit,<BR><BR>The change looks great - but I'd have used a different
testing strategy.<BR><BR>With properties which can't readily be changed at
runtime, I generally use a<BR>different testing strategy. I don't try to
change the property at runtime,<BR>but modify megatest to run the test with
the property set both ways.<BR>Sometimes a test has to recuse itself if the
property setting is<BR>incompatible with the test, but that's OK. The nice
thing is that then all<BR>tests can be run from Main, or indeed
standalone.<BR><BR>To see this, change the line in bin/megatest
from<BR><BR> doTest jdk1.6 access<BR><BR>to<BR><BR> doTest jdk1.6
access mondrian.olap.NullMemberRepresentation=TheNullMember<BR><BR>and you'll
get about 10 failures. Can you fix up the suite so it works<BR>whatever the
value of the property. You should also be able to back out the<BR>ant changes,
such as the junit-nobuild-nomember
target.<BR><BR>Julian<BR><BR><BR></TT></FONT><BR></BLOCKQUOTE></BODY></HTML>