Cheers. Thanx. I'd ask for cvs access, but I'm not that confident of not breaking anything :)<br><br>I'd suggest the following change to AggGen.java as well then. In both cases Iremoved - toUpperCase());<br>
650: agg.getExpression(sqlQuery.getDialect().quoteIdentifier(<br> factTableName, c.getName()))); <br>892: name = usage.getSymbolicName().replace(' ', '_'); // removed - toUpperCase();
<br><br>RolapAggregator.java: // keywords into uppercase - SQL standard and much more readable.<br><br>86: return "COUNT(DISTINCT " + operand + ")"; <br><br>140: buf.append("SUM(");
<br>142: buf.append(") / SUM(");<br><br>170: buf.append("SUM(");<br>
175: buf.append(") / SUM(");<br>
<br>198: buf.append("SUM("); <br><br>228: buf.append(name.toUpperCase()); // expression part in uppercase<br>231: buf.append("DISTINCT "); <br><br><br>also need to fix the expected SQL from reference SQL for
mondrian.rolap.CacheControlTest.java<br>(CacheControlTest.ref.xml - all "sum(" to "SUM(" )<br><br>With these changes, all testcases run without error.<br><br>Cheers. Love mondrian.. just wish I understood more to be able to make more helpful contributions.. but I try - running through a debugger to find where does what is a pain.. but hey... I learn :)) .. java rulez :-)
<br><br>Ati<br><br><br><br><div><span class="gmail_quote">On 10/26/07, <b class="gmail_sendername">Julian Hyde</b> <<a href="mailto:julianhyde@speakeasy.net">julianhyde@speakeasy.net</a>> wrote:</span><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<div>
<div dir="ltr" align="left"><span><font color="#000080" face="Verdana" size="2">I'm not an expert on AggGen. If there are any experts out
there, please chime in. Your changes sound reasonable, so I've checked them in
as change 10108.</font></span></div>
<div dir="ltr" align="left"><span><font color="#000080" face="Verdana" size="2"></font></span> </div>
<div dir="ltr" align="left"><span><font color="#000080" face="Verdana" size="2">Julian</font></span></div><br></div><br></blockquote></div><br>