<html>
<head>
<meta http-equiv=Content-Type content="text/html; charset=us-ascii">
<meta name=Generator content="Microsoft Word 11 (filtered)">
<style>
<!--
/* Font Definitions */
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman";}
a:link, span.MsoHyperlink
{color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{color:purple;
text-decoration:underline;}
span.EmailStyle17
{font-family:Arial;
color:windowtext;}
@page Section1
{size:8.5in 11.0in;
margin:1.0in 1.25in 1.0in 1.25in;}
div.Section1
{page:Section1;}
-->
</style>
</head>
<body lang=EN-US link=blue vlink=purple>
<div class=Section1>
<p class=MsoNormal><font size=2 face=Arial><span style='font-size:10.0pt;
font-family:Arial'>I posted the following message to the Mondrian community
forum a week ago:</span></font></p>
<p class=MsoNormal style='line-height:12.75pt'><font size=1 color=gray
face=Tahoma><span style='font-size:7.0pt;font-family:Tahoma;color:gray'> </span></font></p>
<p class=MsoNormal style='line-height:12.75pt'><font size=1 color=gray
face=Tahoma><span style='font-size:7.0pt;font-family:Tahoma;color:gray'>======================================================================================================================</span></font></p>
<div style='border:none;border-bottom:double windowtext 2.25pt;padding:0in 0in 1.0pt 0in'>
<p class=MsoNormal style='line-height:12.75pt;border:none;padding:0in'><font
size=2 color=gray face=Arial><span style='font-size:10.0pt;font-family:Arial;
color:gray'>Greetings,<br>
<br>
We have a test database that includes some tables that have null data. We ran
some MDX queries against this database using Mondrian 2.3 RC1 and noticed that
about half of the queries produced different results than we received with 2.2.
I have not yet been able to create a standard Mondrian test case for FoodMart
that reproduces the problem, but it can be demonstrated via these steps:<br>
<br>
1) run these 2 INSERTS to add a row with a null promotion_name and a fact table
row that references this promotion row:<br>
<br>
insert into promotion values(7777, 120, NULL, 'TV', 77, '1996-01-10',
'1996-01-12');<br>
insert into sales_fact_1997 values(22, 395, 78, 7777, 11, 6.87, 3.1, 3);<br>
<br>
2) run this simple query:<br>
<br>
select {[Store].[All Stores].[USA].Children} ON COLUMNS,<br>
NON EMPTY {[Promotions].Children} ON ROWS <br>
from [Sales]<br>
<br>
The result on 2.2 shows a value of 3 for the null promotion in the Oregon stores, which I believe is correct. The result on 2.3 shows a different value for Oregon, and also a value for California, though there is no data applicable to California. <br>
<br>
Any help with tracking down this issue and producing a standard regression test
would be appreciated. <br>
<br>
Thanks, Chuck</span></font></p>
</div>
<p class=MsoNormal><font size=2 face=Arial><span style='font-size:10.0pt;
font-family:Arial'> </span></font></p>
<!-- / message -->
<p class=MsoNormal><font size=2 face=Arial><span style='font-size:10.0pt;
font-family:Arial'>Since that posting, I have been able to work on this issue
and believe that I have found the problem. The code in
Aggregation.loadKeys() has been changed for 2.3 to this:</span></font></p>
<p class=MsoNormal><font size=2 face=Arial><span style='font-size:10.0pt;
font-family:Arial'> </span></font></p>
<p class=MsoNormal><font size=2 face=Arial><span style='font-size:10.0pt;
font-family:Arial'> int
loadKeys(SortedSet<Comparable<?>> valueSet, boolean hasNull) {</span></font></p>
<p class=MsoNormal><font size=2 face=Arial><span style='font-size:10.0pt;
font-family:Arial'>
this.hasNull = hasNull;</span></font></p>
<p class=MsoNormal><font size=2 face=Arial><span style='font-size:10.0pt;
font-family:Arial'>
int size = valueSet.size();</span></font></p>
<p class=MsoNormal><font size=2 face=Arial><span style='font-size:10.0pt;
font-family:Arial'>
this.keys = valueSet.toArray(new Comparable<?>[size]);</span></font></p>
<p class=MsoNormal><font size=2 face=Arial><span style='font-size:10.0pt;
font-family:Arial'>
for (int i = 0; i < size; i++) {</span></font></p>
<p class=MsoNormal><font size=2 face=Arial><span style='font-size:10.0pt;
font-family:Arial'>
mapKeyToOffset.put(keys[i], i);</span></font></p>
<p class=MsoNormal><font size=2 face=Arial><span style='font-size:10.0pt;
font-family:Arial'>
}</span></font></p>
<p class=MsoNormal><font size=2 face=Arial><span style='font-size:10.0pt;
font-family:Arial'>
if (hasNull) {</span></font></p>
<p class=MsoNormal><font size=2 face=Arial><span style='font-size:10.0pt;
font-family:Arial'>
mapKeyToOffset.put(RolapUtil.sqlNullValue, size);</span></font></p>
<p class=MsoNormal><font size=2 face=Arial><span style='font-size:10.0pt;
font-family:Arial'>
++size;</span></font></p>
<p class=MsoNormal><font size=2 face=Arial><span style='font-size:10.0pt;
font-family:Arial'>
}</span></font></p>
<p class=MsoNormal><font size=2 face=Arial><span style='font-size:10.0pt;
font-family:Arial'>
return size;</span></font></p>
<p class=MsoNormal><font size=2 face=Arial><span style='font-size:10.0pt;
font-family:Arial'> }</span></font></p>
<p class=MsoNormal><font size=2 face=Arial><span style='font-size:10.0pt;
font-family:Arial'> </span></font></p>
<p class=MsoNormal><font size=2 face=Arial><span style='font-size:10.0pt;
font-family:Arial'>This code sets the keys array from the incoming valueSet,
which is then used to populate the mapKeyToOffset hash map. In the event
of a null value, the hash map is subsequently updated and gets out of sync with
the keys array, which is not updated with the null. The Segment.load()
method gets an incorrect value when it calls axes[j].getKeys().length and duplicate
key values are then used for denseDatasets (or sparseDatasets), leading to
invalid query results. Here is a modified version of the method:</span></font></p>
<p class=MsoNormal><font size=2 face=Arial><span style='font-size:10.0pt;
font-family:Arial'> </span></font></p>
<p class=MsoNormal><font size=2 face=Arial><span style='font-size:10.0pt;
font-family:Arial'> int
loadKeys(SortedSet<Comparable<?>> valueSet, boolean hasNull) {</span></font></p>
<p class=MsoNormal><font size=2 face=Arial><span style='font-size:10.0pt;
font-family:Arial'>
this.hasNull = hasNull;</span></font></p>
<p class=MsoNormal><font size=2 face=Arial><span style='font-size:10.0pt;
font-family:Arial'>
int size = valueSet.size();</span></font></p>
<p class=MsoNormal><font size=2 face=Arial><span style='font-size:10.0pt;
font-family:Arial'>
if (hasNull) {</span></font></p>
<p class=MsoNormal><font size=2 face=Arial><span style='font-size:10.0pt;
font-family:Arial'>
valueSet.add(RolapUtil.sqlNullValue);</span></font></p>
<p class=MsoNormal><font size=2 face=Arial><span style='font-size:10.0pt;
font-family:Arial'>
++size;</span></font></p>
<p class=MsoNormal><font size=2 face=Arial><span style='font-size:10.0pt;
font-family:Arial'>
}</span></font></p>
<p class=MsoNormal><font size=2 face=Arial><span style='font-size:10.0pt;
font-family:Arial'>
this.keys = valueSet.toArray(new Comparable<?>[size]);</span></font></p>
<p class=MsoNormal><font size=2 face=Arial><span style='font-size:10.0pt;
font-family:Arial'>
for (int i = 0; i < size; i++) {</span></font></p>
<p class=MsoNormal><font size=2 face=Arial><span style='font-size:10.0pt;
font-family:Arial'>
mapKeyToOffset.put(keys[i], i);</span></font></p>
<p class=MsoNormal><font size=2 face=Arial><span style='font-size:10.0pt;
font-family:Arial'>
}</span></font></p>
<p class=MsoNormal><font size=2 face=Arial><span style='font-size:10.0pt;
font-family:Arial'>
return size;</span></font></p>
<p class=MsoNormal><font size=2 face=Arial><span style='font-size:10.0pt;
font-family:Arial'> }</span></font></p>
<p class=MsoNormal><font size=2 face=Arial><span style='font-size:10.0pt;
font-family:Arial'> </span></font></p>
<p class=MsoNormal><font size=2 face=Arial><span style='font-size:10.0pt;
font-family:Arial'>and here is the test case that I used:</span></font></p>
<p class=MsoNormal><font size=2 face=Arial><span style='font-size:10.0pt;
font-family:Arial'> </span></font></p>
<p class=MsoNormal><font size=2 face=Arial><span style='font-size:10.0pt;
font-family:Arial'> public void testNullPromotionName() {</span></font></p>
<p class=MsoNormal><font size=2 face=Arial><span style='font-size:10.0pt;
font-family:Arial'> final String
cubeName = "Sales_inline";</span></font></p>
<p class=MsoNormal><font size=2 face=Arial><span style='font-size:10.0pt;
font-family:Arial'> TestContext
testContext = TestContext.create(</span></font></p>
<p class=MsoNormal><font size=2 face=Arial><span style='font-size:10.0pt;
font-family:Arial'>
null,</span></font></p>
<p class=MsoNormal><font size=2 face=Arial><span style='font-size:10.0pt;
font-family:Arial'>
"<Cube name=\"" + cubeName + "\">\n" +</span></font></p>
<p class=MsoNormal><font size=2 face=Arial><span style='font-size:10.0pt;
font-family:Arial'>
" <Table name=\"sales_fact_1997\"/>\n" +</span></font></p>
<p class=MsoNormal><font size=2 face=Arial><span style='font-size:10.0pt;
font-family:Arial'>
" <DimensionUsage name=\"Time\"
source=\"Time\" foreignKey=\"time_id\"/>\n" +</span></font></p>
<p class=MsoNormal><font size=2 face=Arial><span style='font-size:10.0pt;
font-family:Arial'>
" <DimensionUsage name=\"Store\" source=\"Store\"
foreignKey=\"store_id\"/>\n" +</span></font></p>
<p class=MsoNormal><font size=2 face=Arial><span style='font-size:10.0pt;
font-family:Arial'>
" <Dimension name=\"Alternative Promotion\"
foreignKey=\"promotion_id\">\n" +</span></font></p>
<p class=MsoNormal><font size=2 face=Arial><span style='font-size:10.0pt;
font-family:Arial'>
" <Hierarchy hasAll=\"true\"
primaryKey=\"promotion_id\">\n" +</span></font></p>
<p class=MsoNormal><font size=2 face=Arial><span style='font-size:10.0pt;
font-family:Arial'>
" <InlineTable
alias=\"alt_promotion\">\n" +</span></font></p>
<p class=MsoNormal><font size=2 face=Arial><span style='font-size:10.0pt;
font-family:Arial'>
" <ColumnDefs>\n" +</span></font></p>
<p class=MsoNormal><font size=2 face=Arial><span style='font-size:10.0pt;
font-family:Arial'>
" <ColumnDef
name=\"promotion_id\" type=\"Numeric\"/>\n" +</span></font></p>
<p class=MsoNormal><font size=2 face=Arial><span style='font-size:10.0pt;
font-family:Arial'>
" <ColumnDef
name=\"promotion_district_id\"
type=\"Numeric\"/>\n" +</span></font></p>
<p class=MsoNormal><font size=2 face=Arial><span style='font-size:10.0pt;
font-family:Arial'> "
<ColumnDef name=\"promotion_name\"
type=\"String\"/>\n" +</span></font></p>
<p class=MsoNormal><font size=2 face=Arial><span style='font-size:10.0pt;
font-family:Arial'>
" <ColumnDef
name=\"media_type\" type=\"String\"/>\n" +</span></font></p>
<p class=MsoNormal><font size=2 face=Arial><span style='font-size:10.0pt;
font-family:Arial'>
" <ColumnDef
name=\"cost\" type=\"Numeric\"/>\n" +</span></font></p>
<p class=MsoNormal><font size=2 face=Arial><span style='font-size:10.0pt;
font-family:Arial'>
" </ColumnDefs>\n" +</span></font></p>
<p class=MsoNormal><font size=2 face=Arial><span style='font-size:10.0pt;
font-family:Arial'>
" <Rows>\n" +</span></font></p>
<p class=MsoNormal><font size=2 face=Arial><span style='font-size:10.0pt;
font-family:Arial'>
"
<Row>\n" +</span></font></p>
<p class=MsoNormal><font size=2 face=Arial><span style='font-size:10.0pt;
font-family:Arial'>
"
<Value column=\"promotion_id\">0</Value>\n" +</span></font></p>
<p class=MsoNormal><font size=2 face=Arial><span style='font-size:10.0pt;
font-family:Arial'>
"
<Value column=\"promotion_district_id\">120</Value>\n"
+</span></font></p>
<p class=MsoNormal><font size=2 face=Arial><span style='font-size:10.0pt;
font-family:Arial'>
"
<Value column=\"media_type\">TV</Value>\n" +</span></font></p>
<p class=MsoNormal><font size=2 face=Arial><span style='font-size:10.0pt;
font-family:Arial'>
"
<Value column=\"cost\">3</Value>\n" +</span></font></p>
<p class=MsoNormal><font size=2 face=Arial><span style='font-size:10.0pt;
font-family:Arial'>
"
</Row>\n" +</span></font></p>
<p class=MsoNormal><font size=2 face=Arial><span style='font-size:10.0pt;
font-family:Arial'>
"
<Row>\n" +</span></font></p>
<p class=MsoNormal><font size=2 face=Arial><span style='font-size:10.0pt;
font-family:Arial'>
"
<Value column=\"promotion_id\">1</Value>\n" +</span></font></p>
<p class=MsoNormal><font size=2 face=Arial><span style='font-size:10.0pt;
font-family:Arial'>
"
<Value
column=\"promotion_district_id\">120</Value>\n" +</span></font></p>
<p class=MsoNormal><font size=2 face=Arial><span style='font-size:10.0pt;
font-family:Arial'>
"
<Value column=\"promotion_name\">Promo1</Value>\n" +</span></font></p>
<p class=MsoNormal><font size=2 face=Arial><span style='font-size:10.0pt;
font-family:Arial'>
" <Value
column=\"media_type\">Radio</Value>\n" +</span></font></p>
<p class=MsoNormal><font size=2 face=Arial><span style='font-size:10.0pt;
font-family:Arial'>
"
<Value column=\"cost\">5</Value>\n" +</span></font></p>
<p class=MsoNormal><font size=2 face=Arial><span style='font-size:10.0pt;
font-family:Arial'>
"
</Row>\n" +</span></font></p>
<p class=MsoNormal><font size=2 face=Arial><span style='font-size:10.0pt;
font-family:Arial'>
" </Rows>\n" +</span></font></p>
<p class=MsoNormal><font size=2 face=Arial><span style='font-size:10.0pt;
font-family:Arial'>
" </InlineTable>\n" +</span></font></p>
<p class=MsoNormal><font size=2 face=Arial><span style='font-size:10.0pt;
font-family:Arial'>
" <Level name=\"Alternative
Promotion\" column=\"promotion_name\"
uniqueMembers=\"false\"/> \n" +</span></font></p>
<p class=MsoNormal><font size=2 face=Arial><span style='font-size:10.0pt;
font-family:Arial'>
" </Hierarchy>\n" +</span></font></p>
<p class=MsoNormal><font size=2 face=Arial><span style='font-size:10.0pt;
font-family:Arial'>
" </Dimension>\n" +</span></font></p>
<p class=MsoNormal><font size=2 face=Arial><span style='font-size:10.0pt;
font-family:Arial'>
" <Measure name=\"Unit Sales\"
column=\"unit_sales\" aggregator=\"sum\"\n" +</span></font></p>
<p class=MsoNormal><font size=2 face=Arial><span style='font-size:10.0pt;
font-family:Arial'>
" formatString=\"Standard\"
visible=\"false\"/>\n" +</span></font></p>
<p class=MsoNormal><font size=2 face=Arial><span style='font-size:10.0pt;
font-family:Arial'>
" <Measure name=\"Store Sales\"
column=\"store_sales\" aggregator=\"sum\"\n" +</span></font></p>
<p class=MsoNormal><font size=2 face=Arial><span style='font-size:10.0pt;
font-family:Arial'>
"
formatString=\"#,###.00\"/>\n" +</span></font></p>
<p class=MsoNormal><font size=2 face=Arial><span style='font-size:10.0pt;
font-family:Arial'>
"</Cube>",</span></font></p>
<p class=MsoNormal><font size=2 face=Arial><span style='font-size:10.0pt;
font-family:Arial'>
null, null, null);</span></font></p>
<p class=MsoNormal><font size=2 face=Arial><span style='font-size:10.0pt;
font-family:Arial'> </span></font></p>
<p class=MsoNormal><font size=2 face=Arial><span style='font-size:10.0pt;
font-family:Arial'>
testContext.assertQueryReturns(</span></font></p>
<p class=MsoNormal><font size=2 face=Arial><span style='font-size:10.0pt;
font-family:Arial'>
"select {[Store].[All Stores].[USA].Children} ON COLUMNS,\n" +</span></font></p>
<p class=MsoNormal><font size=2 face=Arial><span style='font-size:10.0pt;
font-family:Arial'>
" NON EMPTY {[Alternative Promotion].Children} ON ROWS\n" +</span></font></p>
<p class=MsoNormal><font size=2 face=Arial><span style='font-size:10.0pt;
font-family:Arial'>
"from [" + cubeName + "] ",</span></font></p>
<p class=MsoNormal><font size=2 face=Arial><span style='font-size:10.0pt;
font-family:Arial'>
fold("Axis #0:\n" +</span></font></p>
<p class=MsoNormal><font size=2 face=Arial><span style='font-size:10.0pt;
font-family:Arial'>
"{}\n" +</span></font></p>
<p class=MsoNormal><font size=2 face=Arial><span style='font-size:10.0pt;
font-family:Arial'>
"Axis #1:\n" +</span></font></p>
<p class=MsoNormal><font size=2 face=Arial><span style='font-size:10.0pt;
font-family:Arial'>
"{[Store].[All Stores].[USA].[CA]}\n" +</span></font></p>
<p class=MsoNormal><font size=2 face=Arial><span style='font-size:10.0pt;
font-family:Arial'>
"{[Store].[All Stores].[USA].[OR]}\n" +</span></font></p>
<p class=MsoNormal><font size=2 face=Arial><span style='font-size:10.0pt;
font-family:Arial'>
"{[Store].[All Stores].[USA].[WA]}\n" +</span></font></p>
<p class=MsoNormal><font size=2 face=Arial><span style='font-size:10.0pt;
font-family:Arial'>
"Axis #2:\n" +</span></font></p>
<p class=MsoNormal><font size=2 face=Arial><span style='font-size:10.0pt;
font-family:Arial'>
"{[Alternative Promotion].[All Alternative Promotions].[#null]}\n" +</span></font></p>
<p class=MsoNormal><font size=2 face=Arial><span style='font-size:10.0pt;
font-family:Arial'>
"Row #0: 51,471\n" +</span></font></p>
<p class=MsoNormal><font size=2 face=Arial><span style='font-size:10.0pt;
font-family:Arial'>
"Row #0: 52,469\n" +</span></font></p>
<p class=MsoNormal><font size=2 face=Arial><span style='font-size:10.0pt;
font-family:Arial'>
"Row #0: 91,508\n"));</span></font></p>
<p class=MsoNormal><font size=2 face=Arial><span style='font-size:10.0pt;
font-family:Arial'> }</span></font></p>
<p class=MsoNormal><font size=2 face=Arial><span style='font-size:10.0pt;
font-family:Arial'> </span></font></p>
<p class=MsoNormal><font size=2 face=Arial><span style='font-size:10.0pt;
font-family:Arial'>I stuck the test case in CompatibilityTest for convenience
since I modeled it on the other null tests in that class, but it may be more
appropriate elsewhere. Could Julian or someone else in the developer
community review this work and include it if it passes muster?</span></font></p>
<p class=MsoNormal><font size=2 face=Arial><span style='font-size:10.0pt;
font-family:Arial'> </span></font></p>
<p class=MsoNormal><font size=2 face=Arial><span style='font-size:10.0pt;
font-family:Arial'>Regards, Chuck</span></font></p>
</div>
</body>
</html>