[Mondrian] RE: Eigenbase perforce change 11180 for review

[Julian Hyde]

Thanks for moving this method out of the public API and into ConnectionBase.

Some of the javadoc needs improvement. There are typos, and parameters do
not have descriptions.

>     /**
>      * Parses a query, with specified function table and the mode for
strict 
>      * validation(if true then invalid members are not ignored).
>      * 
>      * This method is only used in testing and bu clients that need to
support customized
>      * parser behavior. That is why this method is not part of the
Connection interface.
>      * 
>      * @param mdxQuery
>      * @param funTable
>      * @param strictValidation
>      * @return Query if parsing is successful
>      */
>     public Query parseQuery(String query, FunTable funTable, boolean
strictValidation) {
>         return parseQuery(query, funTable, false, strictValidation);

The param 'mdxQuery' does not even match the name of the formal parameter
'query'.

Some of the lines are longer than 80 characters.

The 'This method' lines needs to be preceded by '<p>'.

I'd quibble with '@return Query if parsing is successful'. It implies that
the query is null if parsing fails, which is untrue. I suggest

@return Query, not null
@throw MondrianException if parsing fails

Julian